Re: [PATCH] net: wireless: airo semaphore to mutex

From: Daniel Walker
Date: Mon May 26 2008 - 14:00:01 EST



On Mon, 2008-05-26 at 19:29 +0200, Michal Schmidt wrote:
> On Thu, 22 May 2008 16:21:03 -0700
> Daniel Walker <dwalker@xxxxxxxxxx> wrote:
>
> > Signed-off-by: Daniel Walker <dwalker@xxxxxxxxxx>
> >
> > ---
> > drivers/net/wireless/airo.c | 107
> > ++++++++++++++++++++++---------------------- 1 file changed, 54
> > insertions(+), 53 deletions(-)
> >
> > Index: linux-2.6.25/drivers/net/wireless/airo.c
> > ===================================================================
> > --- linux-2.6.25.orig/drivers/net/wireless/airo.c
> > +++ linux-2.6.25/drivers/net/wireless/airo.c
>
> > @@ -3211,7 +3212,7 @@ static irqreturn_t airo_interrupt(int ir
> > set_bit(FLAG_UPDATE_UNI,
> > &apriv->flags); set_bit(FLAG_UPDATE_MULTI, &apriv->flags);
> >
> > - if (down_trylock(&apriv->sem) != 0) {
> > + if (mutex_trylock(&apriv->lock) ==
> > 0) { set_bit(JOB_EVENT, &apriv->jobs);
> > wake_up_interruptible(&apriv->thr_wait);
> > } else
>
>
> Mutexes are not allowed in interrupt context, not even mutex_trylock.

I know .. I must have missed that it was in ISR .. Thanks for noticing
it.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/