Re: [RFC][Patch 5/5]integrity: IMA as an integrity service provider

From: Mimi Zohar
Date: Thu May 29 2008 - 21:58:21 EST



On Thu, 2008-05-29 at 16:35 -0700, Andrew Morton wrote:
> On Thu, 29 May 2008 17:50:34 -0400
> Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:
>
> >
> > On Wed, 2008-05-28 at 20:30 -0700, Andrew Morton wrote:
> >
> > > > ...
> > > >
> > > > > - All the games with mtimes should be described in the changelog too.
> > > >
> > > > Ok. The timespec_recent and mtime issues are part of the same problem
> > > > of detecting when a file has been modified.
> > >
> > > Can't use inode.i_version?
> >
> > i_version is now working on my system.
>
> Oh good.
>
> > It looks good. Is
> > there anything that I need to be concerned about, such as
> > limited filesystem support or the i_version is not updated
> > by file_close for mmaped files?
>
> erk, I'm not an i_version person. It seems that it's only used on
> directories (to patch up readdir coherency problems) so I guess I
> misled you there.

No, no. Initially, that's what I thought. I finally found
file_update_time() calls inode_inc_iversion(), which updates
the i_version. So, it does work. The question is whether
or not it works all the time. :-)

> There's file_struct.f_version, which is no good.
>
> i_generation is no good either.
>
> We've documented these things so wonderfully!
>
> i_writecount looks good?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/