Re: [PATCH] x86: Get irq for hpet timer

[Kevin Hao]

On Thu, 2008-05-29 at 15:32 +0100, Maciej W. Rozycki wrote:

> CONFIG_PCI is optional for the x86 platform.  You could argue this is a
> bug in acpi_register_gsi() and I tend to agree -- I think the existence of
> the ELCR is implied for ACPI-compliant systems, though I am happy to be
> corrected.  The ACPI spec does not mention the register, but quotes:  
> "Existing industry standard register interfaces to: CMOS, PIC, PITs, ..."

Oh, I overlook the existence of CONFIG_PCI.

After look into the code, I think we should add a acpi_pic_set_trigger
to replace eisa_set_level_irq and remove CONFIG_PCI dependency.

> 
>  Anyway, blindly attaching to an IRQ line is not a terribly good idea as
> there may be an edge-triggered line from a device wired there after all. 

Yes, I agree with you. But at present we have not a better way to
resolve this problem. 

Thanks,
Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/