Re: [PATCH 5/4] Fix forcedeth hibernate/wake-on-lan problems

From: Tobias Diedrich
Date: Sat May 31 2008 - 18:55:29 EST


From: Tobias Diedrich <ranma+kernel@xxxxxxxxxxxx>

We currently don't signal the kernel we that this device can wake
the system. Call device_init_wakeup() to correct this.
Without this device_can_wakeup and device_may_wakeup will return
incorrect values.
Together with the minimized acpi wakeup patch (6/4 ;)), which will
follow in the next mail, this really makes wake-on-lan work for me
as expected (i.e. "ethtool -s eth0 wol g" is sufficient, no
additional magic needed).

Signed-off-by: Tobias Diedrich <ranma+kernel@xxxxxxxxxxxx>

Index: linux-2.6.26-rc4.forcedwol/drivers/net/forcedeth.c
===================================================================
--- linux-2.6.26-rc4.forcedwol.orig/drivers/net/forcedeth.c 2008-06-01 00:29:58.000000000 +0200
+++ linux-2.6.26-rc4.forcedwol/drivers/net/forcedeth.c 2008-06-01 00:30:48.000000000 +0200
@@ -5539,6 +5539,11 @@
/* set mac address */
nv_copy_mac_to_hw(dev);

+ /* Workaround current PCI init glitch: wakeup bits aren't
+ * being set from PCI PM capability.
+ */
+ device_init_wakeup(&pci_dev->dev, 1);
+
/* disable WOL */
writel(0, base + NvRegWakeUpFlags);
np->wolenabled = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/