Re: [patch 8/8] vfs: create file_remove_suid() helper

[Miklos Szeredi]

> > From: Miklos Szeredi <mszeredi@xxxxxxx>
> > 
> > All calls to remove_suid() are made with a file pointer.  This is not
> > accidental: similarly to file_update_time(), this function is called
> > when the file is written.
> > 
> > So simplify callers by passing the file pointer instead of the dentry.
> 
> It's not simplifying anything at all.

Yes it is, read the sentence carefully.

>  You just move the pointer
> derefence down one step the callchain without any need.

Which means, that that pointer dereference will be done once instead
of in each caller, no?  It's a gain (albeit a small one) is in code
cleanliness, and possibly in generated code size.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/