Re: [patch 09/15] PNP: make resource assignment functions return0 (success) or -EBUSY (failure)

From: Rene Herman
Date: Sun Jun 01 2008 - 17:55:59 EST


On 31-05-08 00:49, Bjorn Helgaas wrote:

This patch doesn't change any behavior; it just makes the return
values more conventional.

This changes pnp_assign_dma() from a void function to one that
returns an int, just like the other assignment functions. For
now, at least, pnp_assign_dma() always returns 0 (success), so
it appears to never fail, just like before.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>

Acked-by: Rene Herman <rene.herman@xxxxxxxxx>

I believe it would a bit nicer to (as long as we're pretending it matters in the first place) pass the return value back up from pnp_check_foo() instead of returning -EBUSY always but <shrug>

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/