Re: 53052feb6 (PNP: remove pnp_mem_flags() as an lvalue) breaks my ALSA intel8x0 sound card regression

From: Avuton Olrich
Date: Sun Jun 01 2008 - 23:26:10 EST


On Sun, Jun 1, 2008 at 9:20 AM, Rene Herman <rene.herman@xxxxxxxxxxxx> wrote:
> On 01-06-08 16:42, Avuton Olrich wrote:
>
>> My intel8x0 card stops working due to a regression; bisection and
>> information below.
>>
>> May have relationship to this thread
>>
>> http://groups.google.com/group/linux.kernel/browse_thread/thread/d5857287a36e71af/d7ae0a1490b7d142?lnk=st
>>
>> http://avuton.googlepages.com/intel8x0-config.gz
>> http://avuton.googlepages.com/intel8x0-cpuinfo
>> http://avuton.googlepages.com/intel8x0-dmesg
>
> This dmesg seems to be 6-byte file consisting of "dmesg\n" ...

Corrected:
http://avuton.googlepages.com/dmesg.txt

>> http://avuton.googlepages.com/intel8x0-ioports
>> http://avuton.googlepages.com/intel8x0-lspci-vvv
>> http://avuton.googlepages.com/intel8x0-modules
>> http://avuton.googlepages.com/intel8x0-ver-linux
>> http://avuton.googlepages.com/intel8x0-version
>>
>> commit 53052feb6ddd05cb2b5c6e89fb489bf83bbb6803
>> Author: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
>> Date: Mon Apr 28 16:34:15 2008 -0600
>>
>> PNP: remove pnp_mem_flags() as an lvalue
>>
>> A future change will change pnp_mem_flags() from a "#define that
>> simplifies to an lvalue" to "an inline function that returns the
>> flags value."
>>
>> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
>> Acked-By: Rene Herman <rene.herman@xxxxxxxxx>
>> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
>>
>
> I'm probably just really blind but I don't see how that specific commit may
> have made any difference. It _is_ in the exact spot which would fix that
> overlap problem of yours but this should be an identity change as far as
> fuctionality goes. Are you _really_ sure it's this one?
>
> (Is this racing with anything?)

I will confirm in the next 24 hours that the previous revision works.

Thanks,
--
avuton
--
"I've got a fever. And the only prescription is more cowbell." --
Christopher Walken
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/