Re: [patch 2.6.26-rc4-git] PM: boot time suspend selftest

[Andy Whitcroft]

On Thu, May 29, 2008 at 04:22:57PM -0700, Andrew Morton wrote:

> > +static void __init test_wakealarm(struct rtc_device *rtc, suspend_state_t state)
> > +{
> > +	static char		err_readtime [] __initdata =
> > +		KERN_ERR "PM: can't read %s time, err %d\n";
> > +	static char		err_wakealarm [] __initdata =
> > +		KERN_ERR "PM: can't set %s wakealarm, err %d\n";
> > +	static char		err_suspend [] __initdata =
> > +		KERN_ERR "PM: suspend test failed, error %d\n";
> > +	static char		info_test [] __initdata =
> > +		KERN_INFO "PM: test RTC wakeup from '%s' suspend\n";
> 
> - One tab before the variable space is a waste of space.  Two tabs is
>   just extravagant.
> 
> - The space before the [] shouldn't be there.  checkpatch misses this.

Ok, this should be picked up in the next release:

ERROR: space prohibited before open square bracket '['
#1: FILE: Z152.c:1:
+       static char             info_test [] __initdata =

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/