Re: [PATCH] utimensat() non-conformances and fixes [v3]

From: Miklos Szeredi
Date: Tue Jun 03 2008 - 08:17:30 EST


> > > > I'm not sure of the correct way to get the required nameidata (to do a
> > > > vfs_permission() call) from the file descriptor. Can you give me a
> > > > tip there?
> > >
> > > Could you point me at the right way of doing this?
> >
> > You don't need nameidata for this at all. Just call permission() with
> > a NULL nameidata.
> >
> > Ugly API? Yes, will be cleaned up if we manage to find some common
> > ground with the VFS maintainers.
>
> As soon as I'm done with sysctls...

Can't you just do that independently (for now just put a
d_find_alias() in there and be done with it)? If you fix every piece
of horrid code that you come across, it'll never be done...

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/