Re: [PATCH] cputopology: Add default CPU topology information [3rdtry]

[Andrew Morton]

On Sat, 31 May 2008 22:44:30 +0100
Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> wrote:

> Define the macros topology_{physical_package,core}_id() and
> topology_{thread,core}_siblings() in <asm-generic/topology.h> if they are not
> already defined.
> 
> Move inclusion of <asm-generic/topology.h> after definitions of these
> macros in <asm-powerpc/topology.h> and <asm-x86/topology.h>.
> 
> Change drivers/base/topology.c to use the topology macros unconditionally and
> to cope with definitions that aren't lvalues.

Can you please redo this against linux-next?

That tree contains a number of directly conflicting changes.  In
particular, linux-next introduces alternate implementations of
show_##name and show_##name##_list in topology.c and from a quick peek,
your change could make them go away again.

Please also enhance the changelog so we have some idea of why you're
actually doing all this.  What do we gain?  Does it fix a bug?  If so,
what?  etc.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/