Re: aperture_64.c: corner case wrong

From: Ingo Molnar
Date: Wed Jun 04 2008 - 06:45:07 EST



* Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> > So what happened with this? Thomas has merged an "x86:
> > aperture_64.c: cleanups" from yourself but it appears that half of
> > this bugfix got applied somewhere and the below part did not?
>
> Err, no. I seem to have dropped the patch completely. I'm picking it
> up again.

no, it was not dropped (we dont drop patches :), here are all the
arch/x86/kernel/aperture_64.c patches in -tip:

earth4:~/tip> tip-log arch/x86/kernel/aperture_64.c | grep ^#
# x86/gart: 1edc1ab: x86: agp_gart size checking for buggy device
# x86/gart: 8c9fd91: x86: checking aperture size order
# x86/gart: 7677b2e: x86_64: allocate gart aperture from 512M
# x86/gart: 55c0d72: x86: clean up aperture_64.c
# x86/gart: 0abbc78: x86, aperture_64: use symbolic constants
# x86/gart: dd564d0: x86: aperture_64.c: cleanups

so it's commit dd564d0 - but that second chunk Andrew noticed indeed
went missing in action.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/