Re: [PATCH] x86: collapse the various size-dependent percpuaccessors together

From: Ingo Molnar
Date: Wed Jun 04 2008 - 07:30:19 EST



* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Jeremy Fitzhardinge wrote:
>> We can use gcc's %z modifier to emit the appropriate size suffix for
>> an instruction, so we don't need to duplicate the asm statement for
>> each size.
>
> Nah, it's a disaster. Drop this one.

hm, what's the problem with it? What you are trying to do here looks
like a nice cleanup - assuming it results in the same instructions
emitted ;-)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/