Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review!

From: Jean Delvare
Date: Thu Jun 05 2008 - 02:30:19 EST


On Thu, 05 Jun 2008 01:43:46 +0200, Éric Piel wrote:
> 05-06-08 01:05, Pavel Machek wrote/a écrit:
> >> So my advice is that you don't wait for a review from the hwmon people,
> >> because apparently we don't have much interest in this type of device,
> >> so you'll be waiting forever. You're much better adding the mdps driver
> >> to drivers/misc through Andrew Morton, at least until someone takes
> >> care of creating a subsystem for this type of devices and move all
> >> existing drivers there.
> >
> > Just create drivers/accel ... accelerometers are quite common these
> > days. Going to drivers/misc is okay, too, I guess -- moves are easy
> > with git ;-).
>
> Yes, why not do one little step to the correct direction now and create
> drivers/accel, it will likely be the chosen name anyway! That will not
> yet be a "real" subsystem, just a place to put all the related drivers
> already present together.

Well, I would expect all these accelerometer drivers to have a common,
standardized interface, so this should most probably become a real
subsystem in the long run.

> Anyone against this idea?

I am in favor of it.

--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/