Re: [RFC PATCH] drop support for KALLSYMS_EXTRA_PASS

[Keith Owens]

Sam Ravnborg (on Tue, 3 Jun 2008 23:07:32 +0200) wrote:
>We have not seen any reports on inconsistent kallsysms data recently
>as in the last one or two years. At least I do not recall these
>and google had no hits in my searching.
>
>So I suggest removing this as to simplify the final linking.
>When doing "make allyesconfig" build this extra linking
>takes considerably time (and I usually forgoet to turn it off).
>
>In addition this patch removes the debug target: debug_kallsyms
>
>diff --git a/Makefile b/Makefile
>-define verify_kallsyms
>-	$(Q)$(if $($(quiet)cmd_sysmap),                                      \
>-	  echo '  $($(quiet)cmd_sysmap)  .tmp_System.map' &&)                \
>-	  $(cmd_sysmap) .tmp_vmlinux$(last_kallsyms) .tmp_System.map
>-	$(Q)cmp -s System.map .tmp_System.map ||                             \
>-		(echo Inconsistent kallsyms data;                            \
>-		 echo Try setting CONFIG_KALLSYMS_EXTRA_PASS;                \
>-		 rm .tmp_kallsyms* ; /bin/false )
>-endef

I am not happy about removing the check for inconsistent kallsyms data.
Changes to the tool chain could cause this problem to recur and we
would not pick up on it.  If we do keep the check for inconsistent data
then we still need some way for the user to continue while the problem
is investigated.

Since your real complaint seems to be the extra time taken in make
allyesconfig then the solution is easy.  Change CONFIG_KALLSYMS_EXTRA_PASS
to a Makefile option, KALLSYMS_EXTRA_PASS=y.  No extra time required in
make allyesconfig.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/