Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading inmultiples of 8

From: Matt Mackall
Date: Thu Jun 05 2008 - 12:04:54 EST



On Thu, 2008-06-05 at 11:06 -0400, Thomas Tuttle wrote:
> Since kpagecount and kpageflags require reads in multiples of 8, and
> it simplifies add_to_pagemap significantly, I added the same
> requirement to /proc/pid/pagemap.

I'm generally fine with this. Another approach that's perhaps more
friendly is when someone tries to do a 24-byte read, do a 16-byte read,
leaving the file pointer aligned. Not sure if that's completely kosher
though.

--
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/