Re: [PATCH 3/4] pagemap: Return EINVAL, not EIO, for unalignedreads of kpagecount or kpageflags (v2 of series)

From: Matt Mackall
Date: Thu Jun 05 2008 - 14:50:44 EST



On Thu, 2008-06-05 at 14:40 -0400, Thomas Tuttle wrote:
> If the user tries to read from a position that is not a multiple of 8, or
> read a number of bytes that is not a multiple of 8, they have passed an
> invalid argument to read, for the purpose of reading these files. It's
> not an IO error because we didn't encounter any trouble finding the data
> they asked for.

Hmm. I seem to recall choosing EIO because that's what unaligned reads
with direct I/O report. I don't particularly care though.

Acked-by: Matt Mackall <mpm@xxxxxxxxxxx>

--
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/