Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3DACPI driver -- please review!

From: Pavel Machek
Date: Thu Jun 05 2008 - 16:59:31 EST


On Wed 2008-06-04 22:06:47, Henrique de Moraes Holschuh wrote:
> On Thu, 05 Jun 2008, Pavel Machek wrote:
> > > > 3) Makes it possible to power the device off.
> >
> > But this part is what I don't understand. powering off does not seem
> > to belong there. Why can't you just use acpi to power down?
>
> I think he means power down the g-sensors and related filters and A/D
> circuitry. The out-of-tree version of the HDAPS driver can do it as
> well.

Yes, I misunderstood.

> For what is it worth, I think drivers/accel is a good idea, and I think
> the other accel drivers should be moved there.

Agreed.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/