Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data ProtectionSystem 3D ACPI driver -- please review!

From: Dmitry Torokhov
Date: Fri Jun 06 2008 - 10:25:17 EST


Hi,

On Fri, Jun 06, 2008 at 12:27:10AM +0200, Pau Oliva Fora wrote:
> From: Pau Oliva Fora <pau@xxxxxxxxxx>
>
> Add support for HTC Shift UMPC G-Sensor LIS3LV02DL accelerometer.
>
> Signed-off-by: Pau Oliva Fora <pau@xxxxxxxxxx>
>

The input piece looks good, however it seens that the input is the
only functionality that this driver exports so I don't see any reason
to make input device registration optional. Or are you planning on
adding more functions to it?

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/