Re: [PATCH -mm 07/25] second chance replacement for anonymous pages

[Andrew Morton]

On Sat, 07 Jun 2008 15:03:42 +0900 KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:

> > > + * pages.  Ie. a ratio of 3 means 3:1 or 25% of the anonymous pages are
> > > + * on the inactive list.
> > > + *
> > > + * total     return    max
> > > + * memory    value     inactive anon
> > 
> > This function doesn't "return" a "value".
> 
> Sorry, my bad.
> 
> in my country, "return value" is right word.

Not for a function which returns void!

> s/value/ratio/ is better?

Well it's referring to the value of zone->inactive_ratio.  So
replacing "return value" with "zone->inactive_ratio" would be ideal :)

> > 
> > > + * -------------------------------------
> > > + *   10MB       1         5MB
> > > + *  100MB       1        50MB
> > > + *    1GB       3       250MB
> > > + *   10GB      10       0.9GB
> > > + *  100GB      31         3GB
> > > + *    1TB     101        10GB
> > > + *   10TB     320        32GB
> > > + */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/