[PATCH] include/linux/msdos_fs.h: Cleanup include/linux/msdos_fs.h for userspace.

From: S.ÃaÄlar Onur
Date: Sun Jun 08 2008 - 14:18:33 EST


include/linux/msdos_fs.h header should use __u## rather than u## types else any userspace code (like syslinux) includes that header fails to compile like following;

[...]
gcc -Wp,-MT,bootsect_bin.o,-MMD,.bootsect_bin.o.d -W -Wall -D_FILE_OFFSET_BITS=64 -g -Os -I. -I.. -I../libinstaller -c -o bootsect_bin.o ../bootsect_bin.c
gcc -Wp,-MT,ldlinux_bin.o,-MMD,.ldlinux_bin.o.d -W -Wall -D_FILE_OFFSET_BITS=64 -g -Os -I. -I.. -I../libinstaller -c -o ldlinux_bin.o ../ldlinux_bin.c
In file included from syslinux.c:52:
/usr/include/linux/msdos_fs.h:61: error: expected ')' before 'media'
[...]

Noticed by Onur KÃÃÃk <onur@xxxxxxxxxxxxx>

Cc: Frank Seidel <fseidel@xxxxxxx>
CC: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
CC: Onur KÃÃÃk <onur@xxxxxxxxxxxxx>

Signed-off-by: S.ÃaÄlar Onur <caglar@xxxxxxxxxxxxx>

include/linux/msdos_fs.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/msdos_fs.h b/include/linux/msdos_fs.h
index b03b274..3825b1c 100644
--- a/include/linux/msdos_fs.h
+++ b/include/linux/msdos_fs.h
@@ -58,7 +58,7 @@
#define MSDOS_DOTDOT ".. " /* "..", padded to MSDOS_NAME chars */

/* media of boot sector */
-static inline int fat_valid_media(u8 media)
+static inline int fat_valid_media(__u8 media)
{
return 0xf8 <= media || media == 0xf0;
}

Cheers
--
S.ÃaÄlar Onur <caglar@xxxxxxxxxxxxx>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/