Re: [Patch 09/18] base xpc_rsvd_page's timestamp on jiffies

[Andrew Morton]

On Fri, 6 Jun 2008 11:52:16 -0500 Dean Nelson <dcn@xxxxxxx> wrote:

> +	unsigned long stamp;	/* time when reserved page was setup by XPC */

"time" is a rubbery concept in-kernel.  What are the units of this? 
microseconds?  jiffies?  seconds?

At the least, the covering comment should make clear what units this
variable is using.  Better would be to actually embed the units in the
variable's identifier.  Because it's awfulyl easy to make mistakes over
this, and not knowing the units makes the code harder to follow.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/