Re: [PATCH] vmallocinfo: Add NUMA informations

[Christoph Lameter]

On Tue, 3 Jun 2008, Andrew Morton wrote:

> > +	if (NUMA_BUILD) {
> > +		unsigned int *counters, nr;
> > +
> > +		counters = kzalloc(nr_node_ids * sizeof(unsigned int),
> 
> This is kcalloc().  If you like that sorts of thing - I think kcalloc()
> is pretty pointless personally.

Same here. I think its generally ignored. I tried to remove it at some 
point in the past. If we want kcalloc then we also need kczalloc. It would 
be best to keep the interface simple.

> Do we actually need dynamic allocation here?  There's a small,
> constant, known-at-compile-time upper bound to the number of nodes IDs?

The number of node ids may reach 1024.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/