Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on

[Linus Torvalds]

On Mon, 9 Jun 2008, Pavel Machek wrote:
> 
> If your device did not loose power during s2ram, it should just work.

Tough. And if pigs had wings, they could fly. What's your point?

> There's a tweak you can set in /sys you can set if your device is not
> removable, you can set it for non-removable devices that _do_ loose
> power.

Yes, and it's totally pointless. I had this whole discussion already. 
That flag is too hard to find for any normal person to be useful, and the 
fact is, if you hold the device mounted over a suspend, it should be set 
by default anyway.

> Besides, it seems to break suspend/resume of printers, and probably
> all the drivers that do not have reset_resume() method. That's
> actually a regression.
> 
> https://bugzilla.novell.com/show_bug.cgi?id=394820

So printers shouldn't do it, since they aren't mounted. Neither should 
mice etc things. What does that have to do with block devices?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/