Re: [patch 11/11] GRU Driver - makefile & Kconfig file changes

[Roland Dreier]

 > +EXTRA_CFLAGS += -DDEBUG -Werror -Wall

Not sure if it's appropriate to set these flags for your driver...

 > +	---help---
 > +	This option enables basic support for the SGI UV GRU driver. If
 > +	you are not running on a SGI UV system, say N.

"...enables basic support for the SGI UV GRU."  And it would be a good
idea to include some info about what UV GRU does -- your 0/11
introduction mail had a good description that would be nice to have here
as well.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/