Re: [RFC] expand link_power_management_policy definition

From: Tejun Heo
Date: Mon Jun 09 2008 - 22:51:43 EST


Jeff Garzik wrote:
> Kristen Carlson Accardi wrote:
>> I think I mentioned on the list a couple weeks ago that I favor just
>> expanding the definition of link power management to include
>> the notion of simply powering the entire port off rather
>> than adding new knobs to sysfs. I wrote this completely untested and
>> very incomplete patch to give you a better idea of what I am proposing.
>> This patch adds a new valid value of "power_off" for the existing
>> link_power_management_policy sysfs entry:
>
> Looks fine to me... that would work nicely.
>
> I think your patch is missing code to handle the transition from
> power_off to <something else>, though, right?
>
> I'm quite happy with this approach.

I agree this is the right place to implement the control.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/