Re: [PATCH] uio_pdrv: Unique IRQ Mode

[Magnus Damm]

Hi Uwe,

Thanks for your help.

On Mon, Jun 9, 2008 at 9:34 PM, Uwe Kleine-König
<Uwe.Kleine-Koenig@xxxxxxxx> wrote:
> Paul Mundt wrote:
>>                                   [...] the constructive way forward
>> seems to be to follow Uwe's suggestions and respin the patch.
> Just to let you know: I'm willing to look on a new version.  And I like
> "User IRQ Mode".

Sure, let's go with that name then.

But shall we really go down the path with separate exported functions?
I think we discussed that earlier. Why I'm asking is that this adds
extra complexity - function prototypes in header files,
EXPORT_SYMBOL() stuff and more lines of code needed for each driver
instance.

Isn't it enough to add a kconfig option for CONFIG_UIO_PDRV_USER_IRQ
which depends on CONFIG_SUPERH (if we really want that) and wrap the
code in CONFIG_UIO_PDRV_USER_IRQ?

Let me know what you want and I'll respin the patch. Thanks!

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/