Re: [PATCH 06/10] HID: move logitech report quirks

From: Jiri Slaby
Date: Wed Jun 11 2008 - 14:37:24 EST


On 06/11/2008 05:39 PM, Oliver Neukum wrote:
Am Mittwoch 11 Juni 2008 16:13:43 schrieb Jiri Kosina:
On Mon, 9 Jun 2008, Jiri Slaby wrote:

static const struct hid_device_id hid_blacklist[] = {
+ { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_MX3000_RECEIVER) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_S510_RECEIVER)
},
+ { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_S510_RECEIVER_2) },
{ }
};
This shouldn't be needed as soon as the userspace supports the proper module
autoloading, right?
This is needed to tell generic drivers not to bind these, its' generic
blacklist. I have no idea how this could be done better with current
drivers/base/.
Hmm ... but if we make sure that the order in `modules.order' puts all the specialized drivers before the generic one, the binding should be done correctly even without blacklist, right?

No. You might have two devices connected. The first correctly triggers
the loading of the generic driver. The second would first load the specialised
driver but the already loaded driver will be faster.

Hm, the problem here is, that report (supported inputs et al.) parsing needs to be done some time. Since some devices have reports broken too, some of their reports need to be fixed before parsing. So the parsing is postponed after *first* driver binds, then it's checked if the coming driver has report_fixup hook and if yes, it's executed and the device is finally parsed and set up. If it has not (e.g. generic), it's just parsed and set up.

If you bind the generic driver as the first driver and the particular device needs report fixing, it never performs the fixup. Actually what I don't know is how to solve this effectively.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/