Re: [-mm][PATCH 2/4] Setup the memrlimit controller (v5)

[Andrea Righi]

Balbir Singh wrote:
> Andrea Righi wrote:
> > Balbir Singh wrote:
> > > +static int memrlimit_cgroup_write_strategy(char *buf, unsigned long
> > > long *tmp)
> > > +{
> > > +    *tmp = memparse(buf, &buf);
> > > +    if (*buf != '\0')
> > > +        return -EINVAL;
> > > +
> > > +    *tmp = PAGE_ALIGN(*tmp);
> > > +    return 0;
> > > +}
> > We shouldn't use PAGE_ALIGN() here, otherwise we limit the address space
> > to 4GB on 32-bit architectures (that could be reasonable, because this
> > is a per-cgroup limit and not per-process).
>
> You mean un-reasonable?

well... I mean, there would be no reason to apply this fix if it was a
limit per-task on 32-bit. ;-)

-Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/