Re: [PATCH] Fixed NetEm's reorder option

From: Stephen Hemminger
Date: Wed Jun 11 2008 - 17:50:14 EST


On Wed, 11 Jun 2008 17:05:10 -0300
"Rafael Almeida" <almeidaraf@xxxxxxxxx> wrote:

> I noticed no one said anything about my patch below, did I do
> something terrible wrong? Should I just be more patient?
>
> On Thu, Jun 5, 2008 at 1:34 AM, Rafael C. de Almeida
> <almeidaraf@xxxxxxxxx> wrote:
> > The reorder option wasn't working correctly. It would only kick in if
> > the gap option was set. In that case it would only lower the
> > probability of reordering packets because of how the if conditional
> > was stated.
> >
> > This patch separetes the algorithm for reordering with gap from the
> > rest, rendering the code more readable and correct.
> >
> > Signed-off-by: Rafael C. de Almeida <rafaelc@xxxxxxxxxxx>

Haven't had time to look at this in detail, and I worry about the impact
of changing assumptions people already have in their scripts.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/