Re: [PATCH -mm 06/24] vmscan: split LRU lists into anon & file sets

[Hiroshi Shimamoto]

Rik van Riel wrote:
> From: Rik van Riel <riel@xxxxxxxxxx>
> 
> Split the LRU lists in two, one set for pages that are backed by
> real file systems ("file") and one for pages that are backed by
> memory and swap ("anon").  The latter includes tmpfs.
> 
> The advantage of doing this is that the VM will not have to scan
> over lots of anonymous pages (which we generally do not want to
> swap out), just to find the page cache pages that it should evict.
> 
> This patch has the infrastructure and a basic policy to balance
> how much we scan the anon lists and how much we scan the file
> lists. The big policy changes are in separate patches.
> 
> Signed-off-by: Rik van Riel <riel@xxxxxxxxxx>
> Signed-off-by: Lee Schermerhorn <Lee.Schermerhorn@xxxxxx>

Hi,

nitpick

...
> Index: linux-2.6.26-rc5-mm2/mm/page_alloc.c
> ===================================================================
> --- linux-2.6.26-rc5-mm2.orig/mm/page_alloc.c	2008-06-10 13:34:48.000000000 -0400
> +++ linux-2.6.26-rc5-mm2/mm/page_alloc.c	2008-06-10 13:35:23.000000000 -0400
> @@ -1834,10 +1834,13 @@ void show_free_areas(void)
>  		}
>  	}
>  
> -	printk("Active:%lu inactive:%lu dirty:%lu writeback:%lu unstable:%lu\n"
> +	printk("Active_anon:%lu active_file:%lu inactive_anon%lu\n"

inactive_anon:%lu?

thanks,
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/