Re: [PATCH] x86: use add_highpages_with_active_regions for highpages init
From: Ingo Molnar
Date: Sat Jun 14 2008 - 04:24:28 EST
* Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
> use early_node_map to init high pages, so can remove page_is_ram and
> page_is_reserved_early in the big loop with add_one_highpage
>
> also remove the page_is_reserved_early that is not needed.
applied to tip/x86/mpparse for testing, thanks.
Andrew: mm/page_alloc.c modification.
two small nits:
checkpatch warned about:
> + for_each_active_range_index_in_nid(i, nid){
that should be ') {' (note the extra space).
another thing checkpatch noticed:
> +extern void add_one_highpage_init(struct page *, int, int);
> +void __init add_highpages_with_active_regions(int nid, unsigned long start_p$
we want externs in header files.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/