Re: [patch 01/15] MMC: S3C24XX MMC/SD driver. From: Thomas Kleffel<tk@maintech.de>

From: Pierre Ossman
Date: Sat Jun 14 2008 - 12:19:41 EST


On Fri, 06 Jun 2008 16:51:18 +0100
Ben Dooks <ben-linux@xxxxxxxxx> wrote:

> +#include <linux/mmc/mmc.h>

You don't need this anymore.

> + //if(cmd->flags & MMC_RSP_MAYFAIL) debug_as_failure = 0;

Please remove all the dead code.

> + if (mrq->data->error == MMC_ERR_NONE) {

And rebase against HEAD. MMC_ERR_* are long gone.

Also, please test using the mmc_test driver available in HEAD. A proper
driver should pass all those tests (or possibly mark a few as
unsupported if the hardware is utterly incapable of handling those
requests).

Rgds
Pierre

Attachment: signature.asc
Description: PGP signature