Re: [patch 16/47] bluetooth: fix locking bug in the rfcomm socket cleanup handling

[Dave Young]

On Sat, Jun 14, 2008 at 8:26 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Dave,
>
>> > Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
>> > Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
>> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
>> > Signed-off-by: Chris Wright <chrisw@xxxxxxxxxxxx>
>> > ---
>> >  net/bluetooth/rfcomm/core.c |    2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > --- a/net/bluetooth/rfcomm/core.c
>> > +++ b/net/bluetooth/rfcomm/core.c
>> > @@ -423,8 +423,8 @@ static int __rfcomm_dlc_close(struct rfc
>> >
>> >                rfcomm_dlc_lock(d);
>> >                d->state = BT_CLOSED;
>> > -               rfcomm_dlc_unlock(d);
>> >                d->state_change(d, err);
>> > +               rfcomm_dlc_unlock(d);
>> >
>> >                skb_queue_purge(&d->tx_queue);
>> >                rfcomm_dlc_unlink(d);
>
> did we screw up the tabs during the review process here.

Yes, it's due to my use of gmail web interface.
But please don't worry. I usually post patches by mutt, and reply by
gmail web client to easily quote the original message.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/