Re: [PATCH] gigaset: fix module reference counting

From: Tilman Schmidt
Date: Sun Jun 15 2008 - 19:10:43 EST


Hi Andreas,

On 2008-06-07 00:39, Andreas Herrmann wrote:
> bas_gigaset can't be unloaded due to wrong module reference counting.
> Ensure that module_put is called whenever a channel is freed.

I'm not quite happy with that patch. Specifically, I see a risk of
module_put being called too often.

Could you explain in some more detail what bug you are trying to fix?
Do you have a sequence of events which leads to a situation where the
bas_gigaset module cannot be unloaded but should be?


Thanks,
Tilman

Attachment: signature.asc
Description: OpenPGP digital signature