Re: [PATCH] x86: more header fixes

From: Ingo Molnar
Date: Wed Jun 18 2008 - 06:30:32 EST



* Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:

> Hi,
>
> Summary: Add missing include guards for some x86 headers.

applied to tip/x86/cleanups, thanks Vegard.

> This has only had the most rudimentary testing, but is hopefully
> obviously correct. (That's just doomed to generate some sort of build
> failure, isn't it?)

heh ;-)

> PS: I now have a pretty cool framework in Perl for parsing and
> checking headers. And it can be used to transform them automatically
> too. So if you want to standardize the guard format of all the headers
> in one go, we have the means to do it quickly and efficiently...

very nice! I think the reference should be something like the unified
include/asm-x86/processor.h.

could you try a run with that and put the result into a git tree for me
to pull for review? I think we want to finetune that result and do a
flag day for those cleanups, right after all the x86 topics went into
v2.6.27.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/