Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction

From: Jeremy Fitzhardinge
Date: Thu Jun 19 2008 - 01:04:35 EST


Benjamin Herrenschmidt wrote:
On Wed, 2008-06-18 at 17:24 -0700, Linus Torvalds wrote:
On Wed, 18 Jun 2008, Jeremy Fitzhardinge wrote:
Along the lines of:
Hell no. There's a reason we have a special set_wrprotect() thing. We can do it more efficiently on native hardware by just clearing the bit atomically. No need to do the cmpxchg games.

But we can't batch ...

Which architecture are you interested in? If it isn't x86, you can probably get anything past Linus ;)

I'll do some measurements to see what effect the batchable ptep_set_wrprotect() has on native. If it's significant, I'll propose making it conditional on CONFIG_PARAVIRT.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/