Re: [PATCH 2/2] get_user_pages: minor code tweaks

From: Nick Piggin
Date: Sun Jun 22 2008 - 22:45:39 EST


On Sat, Jun 21, 2008 at 06:07:41PM +0400, Oleg Nesterov wrote:
> On 06/21, Oleg Nesterov wrote:
> >
> > No functional changes.
>
> Heh.
>
> > 2. Move "foll_flags |= FOLL_WRITE;" from the inner loop up.
>
> Please ignore this patch, it is wrong. FOLL_WRITE can be cleared after
> handle_mm_fault().

Patch 1/2 is good, though. Please get it upstream.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/