Re: [PATCH] x86: Merge setup_32/64.c into setup.c

From: Ingo Molnar
Date: Wed Jun 25 2008 - 12:43:25 EST



* Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:

> >> include/asm-x86/setup.h | 2
> >> 5 files changed, 670 insertions(+), 934 deletions(-)
> >
> > very nice!
> >
> > could we please split this up into several, gradual steps that bring
> > setup_32.c and setup_64.c to exactly the same content - where the final
> > patch just renames arch/x86/kernel/setup_32.c to arch/x86/kernel/setup.c
> > and deletes arch/x86/kernel/setup_64.c ?
>
> OK, someone (Mike Triavis) already stole setup.c for X86_NUMA.
>
> You need to change that setup.c to other name. or split it away...

hm, that change was supposed to be the seed of a unification. So if it
actually hinders you, feel free to move it to a different file.
Obviously it is setup_32.c and setup_64.c that should be unified into
setup.c.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/