Re: [PATCH 00/16] x86: merge setup_32/64.c

From: Ingo Molnar
Date: Thu Jun 26 2008 - 07:01:57 EST



* Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:

> > #include <asm/mpspec.h>
> > #include <asm/setup.h>
> > #include <asm/arch_hooks.h>
> > +#include <asm/efi.h>
> > #include <asm/sections.h>
> > #include <asm/dmi.h>
> > #include <asm/io_apic.h>
>
> checkpatch.pl want me to remove that.

checkpatch.pl is right about that, but the proper fix would be to decode
this dependency - why isnt it enough to include linux/efi.h?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/