Re: [PATCH 33/60] microblaze_v4: includes SHM*, msgbuf

[Arnd Bergmann]

On Thursday 26 June 2008, monstr@xxxxxxxxx wrote:
>  include/asm-microblaze/msgbuf.h   |   39 ++++++++++++++++++++++++++++
>  include/asm-microblaze/shmbuf.h   |   50 +++++++++++++++++++++++++++++++++++++
>  include/asm-microblaze/shmparam.h |   14 ++++++++++
>  3 files changed, 103 insertions(+), 0 deletions(-)
>  create mode 100644 include/asm-microblaze/msgbuf.h
>  create mode 100644 include/asm-microblaze/shmbuf.h
>  create mode 100644 include/asm-microblaze/shmparam.h
> 

These files are ok, but IMHO they should be in asm-generic, since there
are already many identical copies.

While the implementation of these three, as well as ipcbuf.h and sembuf.h
could be better optimized for endianess and word size differences, I have
come to the conclusion that there is no point for them to really be
different, and uClibc expects this exact layout by default anyway.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/