Re: keyspan_pda.c use of keyspan_pda_get_modem_info

[Alan Cox]

> In these two call sites the callers bail out if
> keyspan_pda_get_modem_info return value is < 0

I don't think that is what the compiler is warning about.

We error on rc < 0
We use the returned status on rc >= 0

We set the returned status on rc > 0

So the rc = 0 case is broken and gcc seems to be correct about that
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/