Re: [PATCH 48/60] microblaze_v4: headers simple files - empty orredirect to asm-generic

From: H. Peter Anvin
Date: Thu Jun 26 2008 - 14:04:42 EST


Arnd Bergmann wrote:
On Thursday 26 June 2008, Adrian Bunk wrote:
The comment could be nuked (as well as the #ifdef __KERNEL__), but for the one #define an asm-generic header would IMHO be overkill.

I agree that it doesn't technically make sense to have a one-line
asm-generic header, but I like the idea of reducing the number of
asm/*.h files that actually contain anything other that
#include <asm-generic/$FILE.h>, mostly for documentation purposes.

If we can eventually agree on a way to get rid of the requirement
for explicit redirection, we can remove a larger number of source
files completely.


The sanest way to do that would probably be something along the lines of:

-> Change include/asm-xxx to arch/xxx/include/asm
-> Create arch/generic
-> Make sure arch/xxx/include/asm and arch/generic/include/asm are both in the include path, in that order.

That would also get rid of the symlink.

On the other hand, the redirection isn't all that bad.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/