Re: [PATCH 3/3] softlockup: fix watchdog task wakeup frequency

[Ingo Molnar]

* Johannes Weiner <hannes@xxxxxxxxxxxx> wrote:

> Wake up the watchdog every second instead of every second. [...]

now _that_ is a real improvement ;-)

>  	/* Wake up the high-prio watchdog task every second: */
> -	if (now > (touch_timestamp + 1))
> +	if (now > touch_timestamp)
>  		wake_up_process(per_cpu(watchdog_task, this_cpu));

you mean wake up every second instead of every two seconds?

i think the best sleep period for the watchdog is half of the threshold. 
It makes no point to check sooner than that. I.e. softlockup_thresh/2 
would be better?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/