Re: [PATCH 12/60] microblaze_v4: Generic dts file for platforms

[Grant Likely]

On Thu, Jun 26, 2008 at 5:29 AM,  <monstr@xxxxxxxxx> wrote:
> From: Michal Simek <monstr@xxxxxxxxx>
>
>
> Signed-off-by: Michal Simek <monstr@xxxxxxxxx>
> ---
>  arch/microblaze/platform/generic/system.dts |  300 +++++++++++++++++++++++++++
>  1 files changed, 300 insertions(+), 0 deletions(-)
>  create mode 100644 arch/microblaze/platform/generic/system.dts

Since this is a generated file, and entirely bitstream specific, does
it make sense to include it in the kernel tree?  If it does, then is
it produced from one of the Xilinx reference designs?  Can you add
documentation to the header that specifies exactly which design
version this .dts is for?

>
> diff --git a/arch/microblaze/platform/generic/system.dts b/arch/microblaze/platform/generic/system.dts
> new file mode 100644
> index 0000000..724a037
> --- /dev/null
> +++ b/arch/microblaze/platform/generic/system.dts
> @@ -0,0 +1,300 @@
> +/*
> + * (C) Copyright 2007-2008 Xilinx, Inc.
> + * (C) Copyright 2007-2008 Michal Simek
> + *
> + * Michal SIMEK <monstr@xxxxxxxxx>

If this is a generated file, then is this copyright notice even appropriate?

> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA

I don't this whole large legal block is necessary.  Unless specified
otherwise in the comment block, I believe GPL licencing is pretty much
assumed and so the above three copyrights should be redundant.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/