Re: [PATCH 02/20] mm: generic show_mem()

From: Johannes Weiner
Date: Sat Jun 28 2008 - 06:26:59 EST


Hi,

Paul Mundt <lethal@xxxxxxxxxxxx> writes:

> On Fri, Jun 27, 2008 at 01:53:51PM +0200, Johannes Weiner wrote:
>> This implements a platform-independent version of show_mem().
>>
>> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxxx>
>
> Looking at this again, does having this as a Kconfig option really make
> sense? We have no tristate in-tree users of this that I can see, wouldn't
> this be better off in lib/? It would be preferable not to let the
> HAVE_foo stuff get out of hand if we can avoid it.

I hate the current Kconfig usage, too. But I figured, if I won't obey
on such decisions by people who maintain it, it won't have a chance to
get in.

So, what do you suggest? Moving it to lib/ and have one simple #define
if the arch wants to use it or not?

Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/