Re: [PATCH 3/3] mmc: Add per-card debugfs support

[Haavard Skinnemoen]

Pierre Ossman <drzeus-mmc@xxxxxxxxx> wrote:
> On Sat, 28 Jun 2008 15:48:44 +0200
> Haavard Skinnemoen <haavard.skinnemoen@xxxxxxxxx> wrote:
> 
> > Pierre Ossman <drzeus-mmc@xxxxxxxxx> wrote:
> > > The status command doesn't work on SDIO cards, so this seems like the
> > > wrong place for it.
> > 
> > Where do you want it then?
> > 
> 
> drivers/mmc/core/mmc.c seems like the correct place (and some coupling
> from sd.c as well). See if you can do something that's similar to how
> sysfs nodes are handled by the bus handlers.

Hmm...I thought card.c seemed like a good place for card-specific debug
information. Even though this particular attribute isn't relevant to
some types of cards, is that a reason to create the whole directory
elsewhere and add complicated dependencies between files?

How about I check card->type and just not create the "status" attribute
for SDIO cards?

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/