Re: [PATCH 6/13] viafb: hw.c, hw.h

[Jiri Slaby]

On 06/30/2008 09:04 AM, JosephChan@xxxxxxxxxx wrote:
> Display hw setting and other chips initialization.
>
>
> Signed-off-by: Joseph Chan <josephchan@xxxxxxxxxx>
>
> diff -Nur a/drivers/video/via/hw.c b/drivers/video/via/hw.c
> --- a/drivers/video/via/hw.c	1970-01-01 08:00:00.000000000 +0800
> +++ b/drivers/video/via/hw.c	2008-06-30 08:53:33.000000000 +0800
> @@ -0,0 +1,2865 @@
[...]
> +#include "global.h"
> +
> +static const struct pci_device_id_info pciidlist[] = {
> +	{PCI_VIA_VENDOR_ID, UNICHROME_CLE266_DID, UNICHROME_CLE266},
> +	{PCI_VIA_VENDOR_ID, UNICHROME_PM800_DID, UNICHROME_PM800},
> +	{PCI_VIA_VENDOR_ID, UNICHROME_K400_DID, UNICHROME_K400},
> +	{PCI_VIA_VENDOR_ID, UNICHROME_K800_DID, UNICHROME_K800},
> +	{PCI_VIA_VENDOR_ID, UNICHROME_CN700_DID, UNICHROME_CN700},
> +	{PCI_VIA_VENDOR_ID, UNICHROME_P4M890_DID, UNICHROME_P4M890},
> +	{PCI_VIA_VENDOR_ID, UNICHROME_K8M890_DID, UNICHROME_K8M890},
> +	{PCI_VIA_VENDOR_ID, UNICHROME_CX700_DID, UNICHROME_CX700},
> +	{PCI_VIA_VENDOR_ID, UNICHROME_P4M900_DID, UNICHROME_P4M900},
> +	{PCI_VIA_VENDOR_ID, UNICHROME_CN750_DID, UNICHROME_CN750},
> +	{PCI_VIA_VENDOR_ID, UNICHROME_VX800_DID, UNICHROME_VX800},
> +	{0, 0, 0}
> +};

Why do you need yet another pci_device_id? How do you insure autoloading?

> +
> +struct offset offset_reg = {
> +	/* IGA1 Offset Register */
> +	{IGA1_OFFSET_REG_NUM, {{CR13, 0, 7}, {CR35, 5, 7} } },
> +	/* IGA2 Offset Register */
> +	{IGA2_OFFSET_REG_NUM, {{CR66, 0, 7}, {CR67, 0, 1} } }
> +};
> +
> +struct pll_map pll_value[] = {

May this be static const (and all of these)?

> +	{CLK_25_175M, CLE266_PLL_25_175M, K800_PLL_25_175M, CX700_25_175M},
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/