RE: [PATCH 3/3] mmc: fix sdio_io sparse errors

From: Winkler, Tomas
Date: Mon Jun 30 2008 - 07:48:23 EST




>-----Original Message-----
>From: Marcel Holtmann [mailto:marcel@xxxxxxxxxxxx]
>Sent: Monday, June 30, 2008 12:01 PM
>To: Winkler, Tomas
>Cc: drzeus-list@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH 3/3] mmc: fix sdio_io sparse errors
>
>Hi Tomas,
>
>> This patch fixes sdio_io sparse errors.
>> This fix changes signature of API functions,
>> changing
>> unsigned char -> u8
>> unsigned short -> u16
>> unsigned long -> u32 - this was probably a bug in 64 bit platforms
>
>why are we not using the new get_unaligned_le* and put_unaligned_le*
>functions for the tmpbuf access?
>
It resides inside sido_func structure there is no reason it will be
unaligned.
Tomas

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/