Re: [PATCH -next] fork and exit: need to include iocontext.h

From: Ingo Molnar
Date: Mon Jun 30 2008 - 14:48:35 EST



* Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> On Mon, 30 Jun 2008 20:33:37 +0200 Ingo Molnar wrote:
>
> >
> > * Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> >
> > > On Mon, 30 Jun 2008 20:05:06 +0200 Ingo Molnar wrote:
> > >
> > > >
> > > > * Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> > > >
> > > > > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> > > > >
> > > > > Fix fork and exit build errors: they need to include iocontext.h:
> > > > >
> > > > > linux-next-20080630/kernel/fork.c: In function 'copy_process':
> > > > > linux-next-20080630/kernel/fork.c:1237: error: implicit declaration of function 'put_io_context'
> > > > > linux-next-20080630/kernel/exit.c: In function 'do_exit':
> > > > > linux-next-20080630/kernel/exit.c:992: error: implicit declaration of function 'exit_io_context'
> > > >
> > > > i havent seen this one - do you know by chance which commit triggers it?
> > >
> > >
> > > Sorry, no idea which commit.
> > >
> > > In 50 randconfigs today (next-20080630), I saw this one 12 times.
> >
> > btw., block.git would be one of my first guesses - Jens Cc:-ed.
> >
> > normally there's an easy way to find out the source commit of build
> > failures. Try something like:
> >
> > git-bisect reset
> > git-bisect start
> > git-bisect good v2.6.26-rc8
> > git-bisect bad linux-next/master
> > git-bisect run make kernel/fork.o
> >
> > ... this should lead you to the commit that broke the build
> > automatically. (as long as everyone keeps make oldconfig compatibility)
>
> Thanks for the steps. Maybe someday I'll use git. ;)

goodies like this are the perfect receipe towards git-addiction ;-)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/