Re: GPE storm detected, disabling EC GPE

From: Andrew Morton
Date: Mon Jun 30 2008 - 15:35:53 EST


On Thu, 5 Jun 2008 21:01:55 +0000
"Justin Mattock" <justinmattock@xxxxxxxxx> wrote:

> FWIW I noticed a post where the person had changed 5 to 20, and it
> seemed to work for them;
> So with that in mind I decide to give that a go, here is the location:
> drivers/acpi/ec.c
> @@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data)
> {
> acpi_status status = AE_OK;
> struct acpi_ec *ec = data;
> u8 state = acpi_ec_read_status(ec);
>
> pr_debug(PREFIX "~~~> interrupt\n");
> atomic_inc(&ec->irq_count);
> - if (atomic_read(&ec->irq_count) > 5) {
> + if (atomic_read(&ec->irq_count) > 20) {
> pr_err(PREFIX "GPE storm detected, disabling EC GPE\n");
> ec_switch_to_poll_mode(ec);
> goto end;
> }
>
> Now I don't know if this will work for other brands, but for
> me(Macbook Pro ATI chipset) I have not received the
> GPE storm detected, disabling EC GPE message, but it's only been an
> hour, maybe after two or three this might appear.
> Also is this good or bad to set 5 to 20 for the system?
> regards;

We've had a few reports of this GPE-storm problem and I've rather lost
track of what's happening. Has anyone looked into it?

If not, do we have a bugzilla report where we can work on this?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/